nebari-dev / nebari-dev/data-science-pack

CI: render chart with NebariApp enabled and add manifest schema validation

Open
#124 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

size: S
Dominant language
Python
Stars
5
Forks
7
Avg merge
1d 20h
Merged PRs (30d)
13

Description

Two [B] checklist items:

helm template renders correctly with NebariApp enabled and disabled
Schema validation passes (kubeconform or equivalent) in CI

lint.yaml currently lints and templates only with --set nebariapp.enabled=false. The enabled path is never rendered in CI; it needs a hostname since templates/nebariapp.yaml requireds one (e.g. --set keycloak.hostname=keycloak.example.com).

There is no kubeconform (or equivalent) step anywhere.

Acceptance criteria:

  • lint.yaml templates the chart twice: nebariapp.enabled=false and nebariapp.enabled=true with a hostname set
  • Rendered manifests validated with kubeconform; the NebariApp CRD will need -ignore-missing-schemas or a converted CRD schema
  • Both run on push/PR like the existing lint steps

Part of #120.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read lint.yaml and templates/nebariapp.yaml, starting with the existing Helm lint and template steps. Add CI rendering for both nebariapp.enabled values, supplying the required hostname for the enabled path, then validate both outputs with kubeconform while handling the NebariApp CRD schema. Done means both checks run on push and pull requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, helm, kubernetes
Domain
ci-cd, devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
74/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.