ndmitchell / ndmitchell/hlint

Extra spaces around "." when using record-dot-preprocessor

Open
#981 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
1.6k
Forks
210
PR merge metrics
No merged PRs in 30d

Description

HLint adds extra spaces around "." in suggestions when record-dot-preprocessor is used.
For example, for this code:

getPersonName :: Person -> String
getPersonName person = (.name) person

getOwnerName :: Company -> String
getOwnerName company = (company.owner.name)

HLint generates these suggestions:

/app/Main.hs:14:1: Warning: Eta reduce
Found:
  getPersonName person = (. name) person
Perhaps:
  getPersonName = (. name)

./app/Main.hs:17:24: Suggestion: Redundant bracket
Found:
  (company . owner . name)
Perhaps:
  company . owner . name

It would be nice if HLint used original formatting around "." .

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the two Haskell examples in the report and inspect how HLint formats suggestions involving record-dot-preprocessor syntax. Trace the formatting path for eta-reduction and redundant-bracket suggestions; done means the suggestions preserve the original spacing around ".".

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.