ndmitchell / ndmitchell/hlint

Reduce duplication hint is unclear

Open
#778 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
1.6k
Forks
210
PR merge metrics
No merged PRs in 30d

Description

I get a reduce duplication hint for following code:

y = ...
foo x = let (a, b) = x `divMod` y in ...
bar x = let (a, b) = x `divMod` y in ...

It is not immediately obvious how it can be simplified.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reduce-duplication hint using the Haskell example in the issue and inspect how that hint is generated. Done means the suggestion clearly explains how the duplicated let bindings can be simplified, with coverage for the shown foo/bar pattern.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.