Parse errors are listed as hints
Open
Nobody has claimed this yet.
good first issue
- Dominant language
- Haskell
- Stars
- 1.6k
- Forks
- 210
- PR merge metrics
- No merged PRs in 30d
Description
When I run hlint on our code base there are 3 parse errors and two hints, however the textual report says "5 hints".
hlint --no-exit-code app test ./lib/pcg-evaluation ./lib/pcg-data-unification ./lib/pcg-error-phase ./lib/pcg-language ./lib/pcg-file-parsers ./lib/pcg-file-source ./lib/pcg-data-normalization ./lib/pcg-alphabet ./lib/pcg-utility ./lib/pcg-serialize ./lib/pcg-tcm-memo ./lib/pcg-core ./lib/pcg-validation-transformer ./lib/pcg-exportable
./lib/pcg-file-parsers/src/File/Format/Fasta/Parser.hs:120:34: Warning: Prefer fold to mconcat
Found:
mconcat
Perhaps:
fold
./lib/pcg-file-parsers/src/File/Format/Fasta/Parser.hs:132:20: Warning: Prefer fold to mconcat
Found:
mconcat
Perhaps:
fold
./lib/pcg-data-normalization/src/Data/Normalization/Metadata/Internal.hs:73:38: Error: Parse error
Found:
where
f NormalizedContinuousCharacter {} = mempty
> f (NormalizedDiscreteCharacter static ) = foldMap toList static
f (NormalizedDynamicCharacter dynamic) = foldMap (foldMap toList) dynamic
./lib/pcg-utility/src/Numeric/Cost.hs:163:21: Error: Parse error
Found:
case hasCycle xs of
Nothing -> let t@(_,r) = (v*10) `quotRem` den in go r $ xs |> t
> Just (static, repeating) -> render static <> addOverline (render repeating)
addOverline = (<>[c]) . intersperse c
./lib/pcg-core/pcg-data-structures/src/Bio/Graph/PhylogeneticDAG/DynamicCharacterRerooting.hs:406:34: Error: Parse error
Found:
deriveMinimalSequenceForDisplayTree = fmap recomputeCost . foldr1 (zipWith minimizeBlock) . fmap createZippableContext
where
> minimizeBlock (static, dynCharVect1) (_, dynCharVect2) = (static, minimizedDynamicCharacterVector)
where
minimizedDynamicCharacterVector = zipWith minimizeDynamicCharacterRooting dynCharVect1 dynCharVect2
5 hints
Parse errors aren't really "hints," so they shouldn't counted in the total.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the report with the shown hlint --no-exit-code command and the listed Haskell source paths, then trace how the textual summary counts warnings and parse errors. Done means parse errors are reported separately from hints and the totals no longer label all five findings as hints.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100