ndmitchell / ndmitchell/hlint

Rule idea: ask to use DerivingStrategies

Open
#690 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
1.6k
Forks
210
PR merge metrics
No merged PRs in 30d

Description

if

  • a module have both DeriveAnyClass and GeneralizedNewtypeDeriving enabled
  • and have a newtype with non-specific deriving clause

then

  • request to enable DerivingStrategies if not already enabled
  • and use specific deriving newtype or anyclass

an example (in this case, probably irrelevant, in general: not so much).

{-# LANGUAGE DeriveAnyClass, GeneralizedNewtypeDeriving #-}

import Data.Hashable

newtype Foo = Foo Int
  deriving (Hashable)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Haskell example in the issue and inspect how HLint rules and their tests are organized. Reproduce the case with both DeriveAnyClass and GeneralizedNewtypeDeriving enabled, then verify that the rule distinguishes non-specific deriving clauses and recognizes an existing DerivingStrategies extension. Done means the requested extension and explicit deriving strategy are suggested for the applicable newtype.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.