ndmitchell / ndmitchell/hlint

Have lhs/rhs match rules apply to types as well as expressions

Open
#449 4 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
1.6k
Forks
210
PR merge metrics
No merged PRs in 30d

Description

I have file:

import Universum

import Control.Monad.Except (ExceptT)

foo :: ExceptT e m a
foo = undefined

and .hlint.yaml:

- warn: { name: "Use 'ExceptT' from Universum"
        , lhs: Control.Monad.Except.ExceptT, rhs: Universum.ExceptT }

I expect hlint to tell me that I should use ExceptT from Universum as I wrote in the rules, but

$ hlint example.hs 
No hints

I'm using hlint v2.0.11.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report with the shown example.hs and .hlint.yaml, using the hlint example.hs command. Start by tracing how lhs/rhs rules are matched against the ExceptT type in the type signature; done means HLint reports the requested replacement from Control.Monad.Except.ExceptT to Universum.ExceptT.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.