Should hlint warn against unidiomatic use of sections?
Nobody has claimed this yet.
- Dominant language
- Haskell
- Stars
- 1.6k
- Forks
- 210
- PR merge metrics
- No merged PRs in 30d
Description
I just bumped into an expression looking like this: (+1) (packetSeq p). Previously it must have been (+1) <$> packetSeq p and suffered a lazy refactoring. I wouldn't have been surprised if HLint wanted to correct this to packetSeq p + 1
I suspect this is probably not a good idea, but thought I'd float it anyway.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reported expression (+1) (packetSeq p) and compare it with the earlier <$> form. Review HLint's existing handling of sections and determine whether this should become a warning; done would require a settled rule, documented expected behavior, and tests for the proposed suggestion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100