ndmitchell / ndmitchell/hlint

Options Not Working In v1.9.41?

Open
#304 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
1.6k
Forks
210
PR merge metrics
No merged PRs in 30d

Description

I recently upgraded to ghc 8.0.2 and stack lts-8.0 from ghc 8.0.1 and stack lts-7.10. Accordingly, I ran stack install hlint to use an hlint built with the new version of ghc.

With the old setup this would work just fine:

eric@linux-epth:total-beginner-haskell$ hlint src/Borrower.hs --hint=Generalise
src/Borrower.hs:44:3: Suggestion: Use mappend
Found:
  getName br ++
    " (" `mappend` show (getMaxBooks br) `mappend` " books)"
Why not:
  getName br `Data.Monoid.mappend`
    (" (" `mappend` show (getMaxBooks br) `mappend` " books)")

1 hint

After the upgrade to v1.9.41 (from v1.9.35 I think) this no longer seems to be working:

eric@linux-epth:total-beginner-haskell$ hlint src/Borrower.hs --hint=Generalise
No hints

How can I correct this?

Thank you.

EDIT: Sorry, got this fixed: hlint src/Borrower.hs --hint=Generalise.hs works correctly...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported commands against HLint v1.9.41, using src/Borrower.hs as the example input, and compare --hint=Generalise with --hint=Generalise.hs. The issue is effectively resolved by the workaround, so any remaining work would be to identify and document why the extension is required.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.