ndmitchell / ndmitchell/hlint

Use newtype instead of data says that the change decreases laziness in the presence of -XStrictData

Open
#285 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
1.6k
Forks
210
PR merge metrics
No merged PRs in 30d

Description

Using newtype over data shouldn't make a difference to the strictness when -XStrictData is active.

src/Foo.hs:73:1: Suggestion: Use newtype instead of data
      Found:
        data Bus = Bus{unBus :: Signed 16}
      Why not:
        newtype Bus = Bus{unBus :: Signed 16}
      Note: decreases laziness

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the src/Foo.hs example with -XStrictData and inspect the HLint rule that emits “Use newtype instead of data.” Verify how the suggestion and its “decreases laziness” note are derived. Done means the tool no longer reports an incorrect strictness difference for this case, with regression coverage for the example.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.