ncbi / ncbi/datasets

`Submitter Names` lack spaces in `dataformat tsv virus-genome` compared to genbank file serialization

Open
#336 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Jupyter Notebook
Stars
559
Forks
70
Avg merge
1m
Merged PRs (30d)
2

Description

Describe the bug
The Submitter Names field has a not-very-robust serialization format of LAST NAME,FIRST NAME INITIALS,LAST NAME,FIRST NAME INITIALS... that does not separate individuals. Is this on purpose, if so why?

When I look up the original genbank file for a sequence, there is a space after the initials, before the next Last Name.

Compare output from

   datasets download virus genome taxon 186538  --no-progressbar  --filename results/ncbi_dataset.zip
 dataformat tsv virus-genome   --package results/ncbi_dataset.zip  --fields submitter-names

for e.g. OR084927 with what's shown for the corresponding .gb file.

CLI output: Kinganda-Lusamaki,E.,Whitmer,S.,Lokilo-Lofiko,E.,Amuri-Aziza,A.,Muyembe-Mawete,F.,Makangara-Cigolo,J.C.,...
Genbank file: Kinganda-Lusamaki,E., Whitmer,S., Lokilo-Lofiko,E., Amuri-Aziza,A., Muyembe-Mawete,F., Makangara-Cigolo,J.C.,

Note that the Genbank file separates names with a whitespace - which is prudent, as otherwise one needs to hope that the parity holds for long strings.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the datasets download virus genome taxon 186538 and dataformat tsv virus-genome --fields submitter-names commands for OR084927, then compare the TSV value with its corresponding GenBank file. Trace the submitter-names serialization entry point and verify that names are separated as in the GenBank output, including a space after each initials sequence.

Written by the indexing model from the issue text.

Assessment

Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.