Add Recorder in fixture-monkey-engine
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Java
- Stars
- 699
- Forks
- 124
- Avg merge
- 24m
- Merged PRs (30d)
- 7
Description
- ArbitraryBuilder 에서 build 시 반환하는 Arbitrary 의 구조를 개선합니다.
- ArbitraryValue 가 Validation 과 ConstratinViolationException 등의 역할을 온전히 하지 못해서 구조를 다시 잡을 필요가 있습니다.
- ArbitraryValue 는 제거하고 ArbitraryBuilder 에서 Validation Filter 를 주입하도록 합니다.
- TooManyFilter... Exception 과 ConstratinViolationException 에 따른 기록과 로깅은 테스트 실패 callback 을 구현해서 기록하게 합니다.
- 기록을 위한 Recorder 설계가 필요합니다.
https://github.com/naver/fixture-monkey/pull/39#issuecomment-932788965
- ArbitraryValue 가 공개 클래스가 아니기 때문에 구조 변경이 사용자에게 영향을 끼치지는 않습니다.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked PR discussion and tracing ArbitraryBuilder, ArbitraryValue, the validation filter, and the test-failure callback. Design the Recorder around the requested restructuring, then confirm that TooManyFilter...Exception and ConstraintViolationException outcomes are recorded and logged through the callback.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100