natverse / natverse/coconat

Show warning when ids are dropped because under threshold

Open
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Currently ids are dropped without warning if it has no partners with connectivity above threshold (default is threshold = 5).
It would be useful to show a warning.

In the example below, the id 720575940622805700 is dropped.

cf_cosine_plot(cf_ids(malecns = "/type:DNge15(4|6)"
,
                      flywire = c("720575940622805700", "720575940636671886")),
               labRow = "{type}_{coconatfly::abbreviate_datasets(dataset)}_{group}_{side}",
               interactive = FALSE
, margins = c(15,10)
)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the cf_cosine_plot and cf_ids entry points using the example in this issue, then locate where IDs without partners above the threshold are discarded. Confirm the default threshold of 5 and the example ID's behavior. Done means a warning identifies dropped IDs without changing the existing filtering behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.