nativescript-community / nativescript-community/ui-pager

BREAKING CHANGE - Can't resolve some modules in 13.0.34

Open
#11 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
21
Forks
14
PR merge metrics
No merged PRs in 30d

Description

After rebuilding node_modules our app couldn't be build anymore. While building you get the following log output errors:

Module not found: Error: Can't resolve '@nativescript/core/data/observable-array' in '/Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript-community/ui-pager/angular/fesm2015'
Did you mean 'index.js'?
BREAKING CHANGE: The request '@nativescript/core/data/observable-array' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.
resolve '@nativescript/core/data/observable-array' in '/Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript-community/ui-pager/angular/fesm2015'
  Parsed request is a module
  using description file: /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript-community/ui-pager/angular/package.json (relative path: ./fesm2015)
    resolve as module
      looking for modules in /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules
        existing directory /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript/core
          using description file: /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript/core/package.json (relative path: .)
            using description file: /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript/core/package.json (relative path: ./data/observable-array)
              /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript/core/data/observable-array is not a file
      /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript-community/ui-pager/angular/fesm2015/node_modules doesn't exist or is not a directory
      /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript-community/ui-pager/angular/node_modules doesn't exist or is not a directory
      /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript-community/ui-pager/node_modules doesn't exist or is not a directory
      /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript-community/node_modules doesn't exist or is not a directory
      /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/node_modules doesn't exist or is not a directory
      looking for modules in /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules
        existing directory /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript/core
          using description file: /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript/core/package.json (relative path: .)
            using description file: /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript/core/package.json (relative path: ./data/observable-array)
              /Users/Shared/Entwicklung/xxx/nativescript-xxx-app/node_modules/@nativescript/core/data/observable-array is not a file
      /Users/Shared/Entwicklung/xxx/node_modules doesn't exist or is not a directory
      /Users/Shared/Entwicklung/node_modules doesn't exist or is not a directory
      /Users/Shared/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
 @ ./src/app/dashboard/dashboard.module.ts 4:0-71 10:134-145
 @ ./src/app/app-routing.module.ts 41:28-70
 @ ./src/app/app.module.ts 26:0-56 189:12-28
 @ ./src/main.ts 6:0-45 10:69-78

The same error appears also for the packages:

  • @nativescript/core/profiling

Because we had
"@nativescript-community/ui-pager": "^13.0.33"
the breaking changes were updated automatically.

We fixed the issue with specifing the previous version with:
"@nativescript-community/ui-pager": "13.0.33"

Let me know, if you need any more information.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the generated Angular fesm2015 output for versions 13.0.33 and 13.0.34, focusing on imports of @nativescript/core/data/observable-array and @nativescript/core/profiling. Reproduce the reported build with the newer version and confirm that the affected modules resolve without requiring the older pinned version.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
build-system, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.