nativescript-community / nativescript-community/ui-label
packaging issue: sideEffects false is incorrect
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 20
- Forks
- 9
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 3
Description
The package declares sideEffects: false but that's not accurate because index-common has a critical top-level side-effect call to overrideSpanAndFormattedString(...) which monkey-patches TextBase.prototype to use NSTextUtils' min/max-line-height semantics.
This adversely affects bundlers that honor this flag.
The fix can publish with sideEffects: true.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the package metadata that declares sideEffects: false and inspect how index-common calls overrideSpanAndFormattedString(...) at top level. Change the published declaration to sideEffects: true, then verify that the package metadata reflects the change and bundlers no longer treat that initialization as safely removable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100