nativescript-community / nativescript-community/ui-drawer
Vue3 Variant removeChild method incorrectly named
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 26
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
Should name the methods called delete and .deleteChild .remove and .removeChild
Without this, if the ~rightDrawer child of <Drawer> is removed, we get errors about missing nodeOps.removeChild method.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/ui-drawer/vue3/index.ts around lines 23-25 and inspect the Vue 3 node-operations method names. Reproduce or inspect the rightDrawer removal path, then confirm the methods use the names expected by nodeOps and that removing the child no longer reports a missing removeChild method.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100