nativescript-community / nativescript-community/ui-chart

Missing export of MPPointF

Open
#56 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
37
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Summary
I'm trying to implement a custom class which implements the IMarker interface.
You have the following definition of the interface in IMarker.d.ts

import { Highlight } from '../highlight/Highlight';

import { Entry } from '../data/Entry';

import { MPPointF } from '../utils/MPPointF';
import { Canvas } from '@nativescript-community/ui-canvas';
export interface IMarker {
    getOffset(): MPPointF;
    getOffsetForDrawingAtPoint(posX: any, posY: any): MPPointF;
    refreshContent(e: Entry, highlight: Highlight): any;
    draw(canvas: Canvas, posX: any, posY: any): any;
}

But it seems like you forgot to export MPPointF for us developers to use. So, I'm unable to import it and implement the 2 methods that are supposed to return the offsets.

Expected Behavior
I expected it to be able to somehow import this in my application. I started with this import statement
import { MPPointF } from '@nativescript-community/ui-chart/utils;
and I've searched in all the folders in your package and I don't see an export for it anywhere

Possible Solution
Please export this and let us know where.

Device (please complete the following information):

  • Device: Pixel 3
  • Android Version Android 13 API v33
  • Library Version : 8.5.0

ADD A REWARD using Speed to SOLVE this issue QUICKLY and SUPPORT this project.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the MPPointF definition referenced by IMarker.d.ts and inspect the package's public export entry points. Verify the intended import path for MPPointF and confirm that a custom IMarker implementation can compile with both offset methods. Done means application code can import MPPointF from the published package.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.