nasa / nasa/sample_app

Overrun warning false alarm for CFE_MSG_Message_t

Open
#158 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
67
Forks
60
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Overrunning struct type CFE_MSG_Message_t of 16 bytes by passing it to a function which accesses it at byte offset 19 using argument 20UL.

Expected behavior
Fix overrun

Code snips
https://github.com/nasa/sample_app/blob/d009197df721af1f430d173584fa64a507a94a13/fsw/src/sample_app.c#L166-L167

System observed on:
Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Reporter Info
Ariel Adams, ASRC Federal

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with fsw/src/sample_app.c at lines 166-167 and review the linked Coverity warning for CFE_MSG_Message_t. Determine whether the reported overrun is a real defect or a false alarm, then verify that the warning is resolved without changing the intended message handling. The issue does not name a test or build command, so use the repository's existing validation steps.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.