nasa / nasa/sample_app

First parameter to `add_cfe_tables` should be app name

Open
#148 0 comments 0 reactions 1 assignee View on GitHub

@jphickey is already working on this.

Since May 17, 2021.

build-system good first issue
Dominant language
C
Stars
67
Forks
60
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
The add_cfe_tables function is declared as follows in arch_build.cmake:
function(add_cfe_tables APP_NAME TBL_SRC_FILES)

The first parameter was intended to be the application name that the table is associated with, but historically any string was accepted since the string just served to make a unique target name.

To Reproduce
Sample_app always passes the string sampleAppTable here.

Expected behavior
Should pass sample_app as first argument.

Code snips
https://github.com/nasa/sample_app/blob/1c32ed48ca358a3fdd55f1bdc9ae0dda61a4f4f7/CMakeLists.txt#L14

System observed on:
Ubuntu

Additional context
No major issue with the current build system, but will may become an issue if/when nasa/cfe#1538 is implemented, and may also become an issue if directory-scope include directories are removed.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.