nasa / nasa/osal

Remove test run from CodeQL workflow

Open
#1,007 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

continuous-integration
Dominant language
C
Stars
670
Forks
277
Avg merge
4d 15h
Merged PRs (30d)
10

Description

Describe the bug
CodeQL workflow is running unit tests which is confusing.

To Reproduce
See https://github.com/nasa/osal/actions/runs/835716057

Expected behavior
Code QL workflow should only run enough of the build steps to run the CodeQL analysis

Alternative
Keep the tests here, rename the workflow, and run the tests and codeql as separate jobs for parallelization

Code snips
https://github.com/nasa/osal/blob/9756b0396807a7dcd64230f01f38e4cad5f3d4f7/.github/workflows/codeql-build.yml#L49-L50

System observed on:
github actions

Additional context
Ensure that new CodeQL workflow in #986 doesn't have the "run tests" step

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect .github/workflows/codeql-build.yml at the referenced lines and compare it with the new CodeQL workflow from #986. Confirm whether the test run is included, then separate or remove it so CodeQL retains only the build steps it needs; the workflow should no longer run unit tests unless they are explicitly placed in a separate job.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, github-actions
Domain
ci-cd, security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.