nasa / nasa/cFS-GroundSystem

TO add subscription command not defined correctly, doesn't accept hex MsgId

Open
#141 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
102
Forks
78
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Tried various settings to get a message limit of 4 (put 4 in each field) and none of them worked. Also doesn't accept 0x880 as a MsgId (seems to require base 10)

To Reproduce
Set MsgId of 0x880:

Traceback (most recent call last):
  File "/export/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/cmdGui/Parameter.py", line 68, in ProcessSendButton
    sendSuccess = self.mcu.sendPacket()
  File "/export/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/cmdGui/MiniCmdUtil.py", line 138, in sendPacket
    self.assemblePacket()
  File "/export/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/cmdGui/MiniCmdUtil.py", line 122, in assemblePacket
    priHeader = self.assemblePriHeader()
  File "/export/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/cmdGui/MiniCmdUtil.py", line 79, in assemblePriHeader
    self.assemblePayload()
  File "/export/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/cmdGui/MiniCmdUtil.py", line 92, in assemblePayload
    dataVal = int(items[1])
ValueError: invalid literal for int() with base 10: '0x880'

Tried with MsgId 2176, tried 4 in every field and TO didn't report a message limit of 4

Expected behavior
Accept hex MsgId, fields should work.

Code snips
TBD

System observed on:

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main

Additional context
Packet may update with nasa/to_lab#73

Reporter Info
Jacob Hageman - NASA/GSFC

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in Subsystems/cmdGui/Parameter.py at ProcessSendButton, then follow sendPacket, assemblePacket, assemblePriHeader, and assemblePayload in MiniCmdUtil.py. Reproduce the 0x880 failure and the subscription command with 4 in each field. Done means hexadecimal MsgId input is accepted and the configured message limit is reported correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.