Clarify code by making array index 0 reserved or unused
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 46
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Description
The command interface to SC identifies RTSs and ATSs starting with 1, but the code identifies them starting with 0. Thus in each command, there is code to adjust the Table Number to the Table Index. Code could be simplified by making array index 0 reserved or unused so that the conversion could be avoided.
Imported from GSFCCFS-1453
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the command handlers that identify RTSs and ATSs and adjust the Table Number to a Table Index. Trace every related table access, then determine whether reserving array index 0 can remove those conversions consistently. Done means the indexing convention is consistent across the commands and existing behavior remains covered by the available tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100