eds2cfetbl tool needs to handle "static" table definitions for backward compatibility
@jphickey is already working on this.
Since Jan 18, 2023.
- Dominant language
- C
- Stars
- 43
- Forks
- 19
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 2
Description
For some reason, many CFS apps instantiated their tables (in C structs) qualified as static. This serves no useful purpose but it breaks the edscfetbl tool which expects to be able to find the symbol by name.
While a workaround is simple (remove static) to get the table to build, this feature of supporting C struct table definitions was intended for backward compatibility, so it would be better if it worked without needing to modify the original table definitions. Having to modify the original table def somewhat defeats the purpose. It seems most, if not all CFS apps have defined the table using static.
Need There may be a way to work around this via the CFE_TBL_FILEDEF macro and possibly tweaking the build rule.
Filing this bug against eds2cfetbl for now, but the fix might involve CFS CMake table build rule changes as well. Need to investigate so this seems like the best place to start.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.