nasa / nasa/EdsLib

Failure to build in Python <= 3.8

Open
#102 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

CCB:Tracked-Internally
Dominant language
C
Stars
43
Forks
19
Avg merge
3d 20h
Merged PRs (30d)
2

Description

Describe the bug
A recent PR uses Py_SET_TYPE -- this was to solve another deprecated / changed API issue.
Unfortunately this was only first added in 3.9, so this broke compatibility with older versions

To Reproduce
Build using Python <= 3.8

Expected behavior
Should work with at least down to 3.6, preferably more.

System observed on:
N/A

Reporter Info
Joseph Hickey, Vantage Systems, Inc (based on other user report)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the C or Python integration code for the Py_SET_TYPE usage and inspect how the project is built against Python versions. Reproduce the build with Python 3.6–3.8, then verify that the compatibility fix also preserves builds on newer Python versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, python
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.