nasa / nasa/CryptoLib

🐛 [BUG] - Fix Key Verification IV values

Open
#446 1 comment 0 reactions 1 assignee View on GitHub

@dccutrig is already working on this.

Since Mar 31, 2025.

bug
Dominant language
C
Stars
169
Forks
67
PR merge metrics
No merged PRs in 30d

Description

Description

Currently keyv just increments a counter, research this a little further and likely need to use the active SA IV (either SA 0 or max for EPs)

Image

I was looking at Crypto_Increment, it only does an increment of +1 on each call. In this example we have a + x + 1... which I think is just so they are all unique. If we use the existing crypto_increment, without the + x, we'd either have to use a for loop X times to increment, or re-write the UTs using it.

Are there any issues with the proposed change along the lines of:

for ( int j=0; j<x; j++ )
{
Crypto_Increment(sdls_ep_keyv_reply.blk[x].iv, SDLS_IV_LEN);
}

I'm unclear on what the second increment could / should be for the line:

sdls_ep_reply[pdu_data_idx - 1] = sdls_ep_reply[pdu_data_idx - 1] + x + 1;

REVIEW this and update.

Branch Name

No response

Reproduction steps
Not blank
Screenshots
![DESCRIPTION](LINK.png)
Logs

OS

Linux

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.