💡 [Magic Number Removal] - CBC Padding parameters in AOS and TM
Open
@Donnie-Ice is already working on this.
Since Mar 18, 2025.
- Dominant language
- C
- Stars
- 169
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
Summary
Look at and review the correct bounds for CBC Padding parameters in AOS and TM, then set thsese as #defines instead of magic numbers (e.g. 16)
Don't blanket use 16 - we need to understand the actual limitations in conjunction with the telemetry frames. (e.g. what happens if we aren't using idle frames... does CBC auto-pad out the whole frame?)
Use Case
Will be needed in future for telemetry support
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.