nasa / nasa/CS

`Name` variable used in events before being filled in

Open
#99 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C
Stars
36
Forks
41
Avg merge
11d 19h
Merged PRs (30d)
2

Description

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Name variable used in final error event before being filled in 2 functions.

Code snips
CS_RecomputeBaselineAppCmd
https://github.com/nasa/CS/blob/f958cc0999fc3dfc76da63478defeed36a6e492d/fsw/src/cs_app_cmds.c#L126-L181

CS_RecomputeBaselineTablesCmd
https://github.com/nasa/CS/blob/f958cc0999fc3dfc76da63478defeed36a6e492d/fsw/src/cs_table_cmds.c#L127-L181

Expected behavior
Fill in before the first if block.

Reporter Info
Avi Weiss   @thnkslprpt

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with CS_RecomputeBaselineAppCmd in fsw/src/cs_app_cmds.c and CS_RecomputeBaselineTablesCmd in fsw/src/cs_table_cmds.c, reviewing the linked ranges around the final error events. Confirm how Name is populated before the first if block and verify that both final error events use the filled value.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.