Use fixed size types for addresses and address offsets in tables/tlm/cmd
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 36
- Forks
- 41
- Avg merge
- 11d 19h
- Merged PRs (30d)
- 2
Description
Checklist (Please check before submitting)
- I reviewed the Contributing Guide.
- I reviewed the README file to see if the feature is in the major future work.
- I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe.
Changing telemetry and table sizes depending on platform (32 vs 64 bit) when using the cpuaddr type in structures.
Describe the solution you'd like
Use cfe_es_memaddress and cfe_es_offset types for tables and telemetry and define those types as 64 bits. If space is an issue, users can redefine these types as 32-bit.
From CCB:2022-04-27
- cpuaddress type will "change size". Use cfe_es_memaddress and cfe_es_offset types for tables and telemetry
- open new issue to address and discuss with customers
Originally posted by @astrogeco in https://github.com/nasa/CS/issues/24#issuecomment-1111211271
EDIT: CFE_ES_MemAddress_t and CFE_ES_MemOffset_t are the actual types that should be used
Describe alternatives you've considered
Leave as is, redefine telemetry sizes based on platform in the "ground system"
Additional context
None
Requester Info
Gerardo E. Cruz-Ortiz, NASA
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the address and offset fields under tables/tlm/cmd and locate the existing cpuaddr type definitions. Compare how these structures determine telemetry and table sizes on 32-bit and 64-bit platforms. Done means using CFE_ES_MemAddress_t and CFE_ES_MemOffset_t consistently, with fixed 64-bit sizes unless users redefine them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100