Removing extraneous parentheses
- Dominant language
- C
- Stars
- 36
- Forks
- 41
- Avg merge
- 11d 19h
- Merged PRs (30d)
- 2
Description
Using the HPSC toolchain flags an error due to extraneous parentheses. Minor edit to resolve.
[ 80%] Building C object apps/cs/CMakeFiles/cs.dir/fsw/src/cs_table_processing.c.o cs_table_processing.c:932:17: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] 932 | if ((Result == CFE_TBL_INFO_UPDATED)) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ cs_table_processing.c:932:17: note: remove extraneous parentheses around the comparison to silence this warning 932 | if ((Result == CFE_TBL_INFO_UPDATED)) | ~ ^ ~ cs_table_processing.c:932:17: note: use '=' to turn this equality comparison into an assignment 932 | if ((Result == CFE_TBL_INFO_UPDATED))
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open apps/cs/fsw/src/cs_table_processing.c and inspect line 932, where the HPSC toolchain reports extraneous parentheses in the equality check. Remove only the reported parentheses and rerun the HPSC build; done means the file compiles without the parentheses-equality error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 84/100