CS tests have a few minor bugs to clean up
Open
Nobody has claimed this yet.
bug
unit-test
- Dominant language
- C
- Stars
- 36
- Forks
- 41
- Avg merge
- 11d 19h
- Merged PRs (30d)
- 2
Description
Checklist
- I reviewed the Contributing Guide.
- I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.
Describe the bug
There are a few duplicate asserts and out-of-order UT_Set* functions that are run after the test function has already been called.
Expected behavior
Correct tests.
Reporter Info
Avi Weiss @thnkslprpt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with unit-test/cs_app_cmds_tests.c at the linked lines 378-380 and 490-494. Inspect the surrounding tests for duplicate asserts and UT_Set* calls that occur after the test function runs. Correct those test-ordering issues, then run the CS unit-test suite to confirm the tests behave as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100