CS_Enable/Disable/Get EntryID functions clean-up
Open
Beginner friendly
Nobody has claimed this yet.
bug
- Dominant language
- C
- Stars
- 36
- Forks
- 41
- Avg merge
- 11d 19h
- Merged PRs (30d)
- 2
Description
Checklist
- I reviewed the Contributing Guide.
- I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.
Describe the bug
CS_EnableEntryIDMemoryCmd, CS_DisableEntryIDMemoryCmd and CS_GetEntryIDMemoryCmd use some unnecessary intermediate variables and also use the wrong State variable in their debug event strings.
Reporter Info
Avi Weiss @thnkslprpt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in fsw/src/cs_memory_cmds.c around the CS_EnableEntryIDMemoryCmd, CS_DisableEntryIDMemoryCmd, and CS_GetEntryIDMemoryCmd functions referenced by the issue. Inspect the intermediate variables and the State values used in their debug event strings. Done means the unnecessary variables are removed and each debug string uses the correct State variable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 70/100