`CS_EnableEntryIDEepromCmd` reporting the wrong `State` variable in error event
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 36
- Forks
- 41
- Avg merge
- 11d 19h
- Merged PRs (30d)
- 2
Description
Checklist
- I reviewed the Contributing Guide.
- I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.
Describe the bug
It seems like the error event (CS_ENABLE_EEPROM_DEF_EMPTY_DBG_EID) in CS_EnableEntryIDEepromCmd probably wants the CS_AppData.DefEepromTblPtr[EntryID] State, not the local function State variable, which is intended for use in the CS_ENABLE_EEPROM_INVALID_ENTRY_ERR_EID event message.
Expected behavior
Use the correct State in the error event.
Reporter Info
Avi Weiss @thnkslprpt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in fsw/src/cs_eeprom_cmds.c around CS_EnableEntryIDEepromCmd, especially lines 223-276 and the CS_ENABLE_EEPROM_DEF_EMPTY_DBG_EID event. Compare the State used by that event with the nearby invalid-entry event. Done means the empty-definition error reports the definition table entry's state, with the relevant checksum application tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100