`RecomputeInProgress` checked for `false` and then immediately assigned `false`
Open
Nobody has claimed this yet.
bug
- Dominant language
- C
- Stars
- 36
- Forks
- 41
- Avg merge
- 11d 19h
- Merged PRs (30d)
- 2
Description
Checklist
- I reviewed the Contributing Guide.
- I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.
Describe the bug
RecomputeInProgress checked for false and then immediately assigned false
Code snips
https://github.com/nasa/CS/blob/f958cc0999fc3dfc76da63478defeed36a6e492d/fsw/src/cs_cmds.c#L455-L459
https://github.com/nasa/CS/blob/f958cc0999fc3dfc76da63478defeed36a6e492d/fsw/src/cs_cmds.c#L526-L534
Expected behavior
Remove redundant assignment to simplify function.
Reporter Info
Avi Weiss @thnkslprpt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open fsw/src/cs_cmds.c and inspect the two referenced ranges, lines 455-459 and 526-534. Confirm where RecomputeInProgress is checked and redundantly assigned, then remove the unnecessary assignment and verify both code paths remain correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100