nasa / nasa/CF

Default TX/RX Msg IDs swapped between CMD/TLM types

Open Beginner friendly
#488 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C
Stars
120
Forks
77
Avg merge
7d 18h
Merged PRs (30d)
3

Description

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
In the 7.0.0 release, the default CF_TX_MID were swapped from TLM to CMD message types and the default CF__RX_MID were swapped from CMD to TLM message types when updating to use a different macro to define them.

To Reproduce
Look at the recent source diffs for default_cf_msgids.h to see the swap.

Expected behavior
Should be swapped back to be consistent with comment in the cf_topicids.h

Code snips
If applicable, add references to the software.

System observed on:
N/A

Additional context
N/A

Reporter Info
Jeremy Donde
General Atomics
jeremy.donde@ga.com

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the recent source changes in default_cf_msgids.h with the comments in cf_topicids.h. Check the default CF_TX_MID and CF__RX_MID assignments against those documented message types. Done means the defaults are restored consistently with the cf_topicids.h comments.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.