nasa / nasa/CF

EotPacket provides transaction status, but defines are internal

Open
#449 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
120
Forks
77
Avg merge
7d 18h
Merged PRs (30d)
3

Description

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the CF README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Eot provides transaction status:
https://github.com/nasa/CF/blob/12eff1c97935942fb9aaa57f44c5ad50918b35b4/fsw/src/cf_cfdp.c#L1732

Values are internal:
https://github.com/nasa/CF/blob/12eff1c97935942fb9aaa57f44c5ad50918b35b4/fsw/src/cf_cfdp_types.h#L132-L166

Describe the solution you'd like
To be of any real use these should be exposed, probably in default_cf_extern_typedefs.h

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the transaction-status definitions in fsw/src/cf_cfdp_types.h with their use in fsw/src/cf_cfdp.c. Then inspect default_cf_extern_typedefs.h and determine how those definitions are exposed publicly. Done means the EotPacket transaction-status values are available through the intended external typedef header.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.