Binaries via optional dependencies doesn't get correct arch for Electron
Open
@Brooooooklyn is already working on this.
Since Apr 7, 2021.
- Dominant language
- Rust
- Stars
- 1.5k
- Forks
- 52
- Avg merge
- 13h 37m
- Merged PRs (30d)
- 19
Description
When using electron-forge or electron-builder we generally build our Windows apps for both ia32 and x64.
On the surface, the optional dependencies route seems like a good idea but it doesn't work in the above case because npm optional modules are installed for the current nodejs architecture, not for the target Electron arch.
None of the Electron tooling appears aware of binaries via optional dependencies route so it doesn't work for one of the architectures.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.