nammayatri / nammayatri/shared-kernel
Similarly named fields in record.
Nobody has claimed this yet.
- Dominant language
- Haskell
- Stars
- 24
- Forks
- 11
- Avg merge
- 15h 16m
- Merged PRs (30d)
- 35
Description
Discussion
While reading through the code i came across two similarly named fields color and colour in a record type here
Do we really need both of them? I think they represent the same thing (the color of the vehicle as mention on the RC) and just differ in the spelling i.e. American vs Common-wealth English. I think we can get rid of one of those.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/mobility-core/src/Kernel/External/Verification/Idfy/Types/Response.hs around lines 90-91. Trace usages of both color and colour and compare how the vehicle colour from the RC is represented before deciding whether they are interchangeable. Done means one consistent field remains and all affected references are updated without changing the intended response data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100