nais / nais/deploy

Log and trace links are not multi tenant

Open
#314 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
3
Forks
9
Avg merge
7h 4m
Merged PRs (30d)
3

Description

in #313 there's a link to a trace for the deployment but it points at grafana.nav.cloud.nais.io and not to the tenants instance. It should point to grafana.$tenant.cloud.nais.io.

This link also points to a dashboard for traces that the other tenants do not have and has been broken since september last year across all non-Nav tenants.

in the near future when grafana 12 happens , we will be able to provision dashboards for stuff like this from github repos which means that we will be able to make these links work consistently across tenants.

The severity of this issues is mitigated somewhat by the fact that the logs from the deploy client pretty much says all you need to know.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the deployment trace link described in #313 and trace where its Grafana URL and dashboard target are assembled. Verify that generated links use the tenant's Grafana host and work for non-Nav tenants; done means log and trace links resolve to tenant-available destinations.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, grafana
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.