nais / nais/cli

Failure when api adds new types to GraphQL interfaces

Open
#749 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
2
Forks
5
Avg merge
17m
Merged PRs (30d)
11

Description

When the API returns a new type from a query returning an interface, the client is throwing an "unexpected concrete type for" error.

So it requires pulling the schema and then regenerate graphql. We should look into how not to throw an error, given that the interface fields should be enough

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the GraphQL client code that handles interface results and produces the "unexpected concrete type for" error, then reproduce the failure with a newly returned API type. Done means the client no longer requires schema regeneration for this case and tests cover the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.