myclabs / myclabs/DeepCopy

Move to an immutable API

Open
#68 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
8.9k
Forks
110
PR merge metrics
No merged PRs in 30d

Description

I'm not really sure what's the interest of having an addFilter and co. when everything could be added in the constructor.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating addFilter and the constructor in the repository, then review related API methods and their tests. Define the intended immutable construction pattern and update the API consistently, with tests showing that configuration is supplied through construction and mutation methods are no longer required.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.