musescore / musescore/MuseScore
(internally) Fix default placement of newly created `Breath`
Open
Beginner friendly
Nobody has claimed this yet.
P4
tech debt
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
As seen in https://github.com/musescore/MuseScore/pull/28969/files#r2234122577, newly constructed Breath objects incorrectly have Placement::BELOW, which doesn't match the default value. This is solved by setting the placement explicitly almost every time after constructing a Breath, but that shouldn't be necessary.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the Breath class and its Placement initialization, then inspect the construction sites discussed in pull request 28969. Confirm that a newly constructed Breath receives the intended default placement without repeated explicit assignment, and verify existing placement behavior remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100