musescore / musescore/MuseScore
Stopping playback after the last note should put the playhead back to the start even if the reverb tail hasn’t finished playing
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
Description
Currently, after playback reaches the end of the score, it continues playing for a second or two, I presume so that any possible reverb tail does not get cut short.
But I think that when the user stops playback after it reaches the end of the score, but before the reverb tail has finished, the playhead should still immediately be set to the beginning.
Consider this scenario
You play a score to the end and stop it yourself while the reverb tail is still playing. You press the spacebar, expecting the score to play from the start (as this was the behaviour in MS3) and you hear nothing. “Well,” you think, “maybe I didn’t press it right,” so you press it again, but this time it actually stops the playback again, because really it was playing, it’s just that it was playing the reverb tail, which was silent.
I can see that this could be a bit confusing for new users. For me, it's a bit frustrating, and something that I think could be fairly easily solved.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the playback stop handling when a score reaches its end and the reverb tail is still playing. Reproduce the spacebar scenario described in the issue, then verify that stopping during the tail resets the playhead immediately and that the next spacebar press starts playback from the beginning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100