musescore / musescore/MuseScore
[Tech Debt] Score elements popups. Reuse positionig from popup view instead of manual positioning in qml for each popup
@Eism is already working on this.
Since Mar 11, 2025.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
ElementPopupLoader has a list of all popups for score: if we look at each of them, we will see updatePosition function, which adjusts the position depending on the parent position and the popup size.
The same is done in the PopupView class. We should correctly configure the popup view component (set anchorItem, select the correct parent, set the preferred side for positioning) and automatic positioning should work for each popup. (The positioning system for PopupView may need to be improved)
This will remove code duplication, and also protect us from such bugs positioning the popup offscreen
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.