musescore / musescore/MuseScore

Dynamics popup refinements (lower-priority)

Open
#26,019 2 comments 0 reactions 1 assignee View on GitHub

@cbjeukendrup is already working on this.

Since Jan 8, 2025.

P3 Pre-release feature issue UI UX/interaction
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Refinements to https://github.com/musescore/MuseScore/pull/24125

See issues 4, 5, 7, 8, and 9 from my comment here (pasted below, but there's some discussion at the link)


  1. If I click on the dynamic again after selecting it, the popup should be dismissed. Clicking it again should open it again. See the sound flag popup for an example of how this is already implemented. Example of why you'd want this: the popup is dismissed when scrolled (expected behavior), but you have to deselect and reselect the dynamic if you want to see the popup again.

https://github.com/user-attachments/assets/83db0024-a6f2-4eee-ab02-37d4087ebc62

  1. When I click a dynamic in the score that isn't on the first page of the popup, it should call up the page it's on.
    Current behavior (the first page shows up every time):
    image
    Expected behavior:
    image

  2. When clicking the left arrow to cycle through pages, the rightmost dynamic in the popup has the darker hover state, but it shouldn't

https://github.com/user-attachments/assets/693cd95e-48e1-4537-8520-38090761b770

(Video for both 8 and 9 below)

  1. Fixed by #26777 If a dynamic is selected that is immediately followed by a crescendo/decrescendo that is snapped to the dynamic, using the cresc/dec buttons in the popup currently add additional hairpin objects. Perhaps they should replace the existing one when clicked (or do nothing if a crescendo exists and a crescendo is clicked).

  2. The popup shifts around a little bit when different dynamics are selected. It would be nice if the popup remained in the same place while clicking different dynamics. The position could then update the next time the popup is opened.

https://github.com/user-attachments/assets/03c769d7-d06b-4d42-97ec-475fd80fa726

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.