musescore / musescore/MuseScore

Refactor code for adding time signatures

Open
#25,658 0 comments 0 reactions 2 assignees View on GitHub

Nobody has claimed this yet.

tech debt
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

As discovered in #25613, the code for adding time signatures can use a bit of a cleanup. While reviewing that PR, which, among other things, improves the names of the variables, it became clear that especially inside Score::cmdAddTimeSig, there are some bugs hiding there; and the code is difficult to read.

Could be done whenever we happen to do something with time signatures.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.