musescore / musescore/MuseScore

Make tooltips dynamic in note input toolbar (and beyond)

Open
#25,005 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

P3 UI
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Your idea

Depending on context, some of the information displayed in the tooltips for the note input toolbar is incorrect.

Problem to be solved
Issue 1

Current behavior:
If you set a custom shortcut for any of the buttons in the note input toolbar, the tooltip continues to display the old shortcut. Presumably this is an issue in other tooltips too, but we should check.

https://github.com/user-attachments/assets/a25c5892-5b21-49fc-9e5d-0fbdffd1f5c9

Expected behavior:
When shortcuts are changed, tooltips show the new shortcut.

Issue 2

Current behavior:
Some shortcuts change depending on context. For instance, the duration buttons in the note input toolbar can be toggled using number keys, but if you're on a tablature staff, the shortcut is Shift + [Number] because the number keys are used for note entry.
image

However, the tooltip always shows the non-tablature shortcut.
image

Expected behavior:
If I'm in note input mode on a tablature staff, we should show the correct shortcut (including Shift) in the tooltip.

Issue 3

Current behavior:
Similarly to above, the descriptive text in tooltips sometimes should be different depending on context.

Take the rest button. First off, the shortcuts are missing entirely from this tooltip, so we should add them.
image
image

But notice that the tooltip says "Toggle rest" and the shortcuts are "Enter rest". Perhaps the shortcut was hidden because pressing the button in the toolbar and using the shortcut technically do two different things, but I think it's worth being slightly imprecise in order to surface that shortcut to new users so they can try it and see what it does.

So I'd recommend we just always display the shortcut here, and change the text depending on the shortcut's function in the note input mode you're in:

  • In 'Default (step time)' and 'Repitch existing notes' modes, it should say "Toggle/enter rest" (it toggles if you click, and enters rests if you press 0)
  • In 'Rhythm only (not pitch)' mode, it should stay as "Toggle rest"
Prior art

No response

Additional context

No response

Checklist
  • This request follows the guidelines for reporting issues
  • I have verified that this feature request has not been logged before, by searching the issue tracker for similar requests

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.