musescore / musescore/MuseScore
NetworkManager. Asynchronous requests
Open
Nobody has claimed this yet.
tech debt
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
Your idea
Implement asynchronous requests in the network in NetworkManager
These should be async::Promise with data or error codes if they could not be received.
Problem to be solved
Will solve the problem with blocking the main thread during requests.
Prior art
No response
Additional context
No response
Checklist
- This request follows the guidelines for reporting issues
- I have verified that this feature request has not been logged before, by searching the issue tracker for similar requests
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/framework/network/internal/networkmanager.h and trace how NetworkManager currently performs requests. Define the asynchronous request flow around async::Promise, including data and error-code results, and verify that requests no longer block the main thread. The issue names no tests or other entry points.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100