musescore / musescore/MuseScore

Support for automatic correction of dynamic markings saved before 4.4

Open
#24,083 0 comments 0 reactions 1 assignee View on GitHub

@cbjeukendrup is already working on this.

Since Aug 20, 2024.

feature request
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Your idea

In MuseScore Studio before version 4.4, the user could assign dynamics to both the first and second voices (although this did not affect the sound in any way, but at least the dynamics were displayed in the appropriate color, for example, for the 1st voice - blue, for the 2nd green, etc.).
When opened in MuseScore Studio 4.4. the dynamic assigned in early versions to the 2nd voice retains its property, but the dynamic assigned to the 1st voice is somehow displayed in the properties as assigned to "All". I understand that such a rule could be applied if there is no second voice in the staff (or if there is one, but without the dynamics assigned to the second voice), but if there is the dynamic for the second voice, wouldn't it be more logical to divide the dynamics by voices accordingly?

https://github.com/user-attachments/assets/86ca552b-0b57-4496-b8c1-56b8972ff8ef

Problem to be solved

It is very strange to imagine such a system in which (if there are two or more voices on the staff) one dynamic can be assigned to a particular voice, and the other to "All". Then what's the point of having some dynamics assigned to a particular voice if it doesn't have an impact anyway, since there is another dynamic that is assigned to "All". It would be nice to add one simple rule in this case: if there is already some dynamics on the staff, and it is assigned to a particular voice, then another dynamics can no longer be assigned to "All", but only to voices, except for that particular voice to which its own dynamics has already been assigned (or to "All" for with the exception of the voice to which the dynamic has already been assigned, but only in such a way that it would be directly spelled out so that the user could see and understand, for example: "All except 2" or something like that).

This will avoid confusion.

Prior art

No response

Additional context

The same applies to the dynamics, which were originally conceived to be assigned to particular staffs of the instrument. When opened in MuseScore Studio 4.4, each dynamic of each staff is automatically assigned to "All", which is not entirely logical.

https://github.com/user-attachments/assets/00f64589-f980-4faa-b61e-93b3a8944977

It would be great if, when opening scores saved before version 4.4, the dynamics would be assigned only to the staff, and not to "All":

https://github.com/user-attachments/assets/1765b1d2-80fb-4b7f-8613-79c7e866e214

Checklist
  • This request follows the guidelines for reporting issues
  • I have verified that this feature request has not been logged before, by searching the issue tracker for similar requests

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.