musescore / musescore/MuseScore
Refine the way we work with macOS dependencies on CI
Open
@cbjeukendrup is already working on this.
Since Jul 19, 2024.
dev
os: macOS
P2
tech debt
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
See https://github.com/musescore/MuseScore/pull/23643#issuecomment-2235219884.
At the moment, the dependencies are stored in a repository in my personal account: https://github.com/cbjeukendrup/musescore_deps
We should decide on a more sustainable solution for that.
- One option: moving it to the musescore organisation
- Another option: merge it somehow with the muse_deps repo
- Problem: it is desirable to "install" all dependencies into one folder, because they also depend on each other and that makes it easier to find them because you just need to add one directory to either PATH or CMAKE_PREFIX_PATH. The muse_deps repo currently doesn't follow that principle
- In any case, it might be nice to make a similar approach for the Windows and macOS dependencies
- On the other hand, on macOS, for local builds, using the HomeBrew libs is perfectly fine, so this precompiled dependencies folder is optional; on Windows that's different.
- (By the way, it seems that the Windows dependencies are currently loaded both in
src/framework/cmake/MuseFetchDependencies.cmakeandbuildscripts/ci/windows/setup.bat; that's perhaps redundant)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.