musescore / musescore/MuseScore

[VST] Notes are not retriggered correctly during playback and note input

Open
#23,364 0 comments 0 reactions 1 assignee View on GitHub

@zacjansheski is already working on this.

Since Jun 28, 2024.

needs review
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Issue type

VST Bug

Bug description

I report three issues which I believe pertain to the same kind of behaviour for VSTs:

  1. Playback is not triggered at all in two cases: (a) if it is stopped and restarted at the same position, and (b) if the playback cursor is located on a tied note. See the video below (at the end, incidentally, you will notice that there is a weird playback artifact on the third staff that uses Muse Sounds):
    https://github.com/musescore/MuseScore/assets/120221700/7c86df37-e667-41b4-ba65-29165d011bf0
  2. Playback and note-input preview are not correctly retriggered (that is, notes are not triggered from the beginning) if playback was stopped abruptly. Instead, the new sounds are superimposed on the end of the sound that was stopped suddenly. This is conspicuous for sustained sounds, as shown in the video below, but it is likely to happen for short sounds too (to back up this point, see point 3. below).
    https://github.com/musescore/MuseScore/assets/120221700/dafe89d4-4742-4058-9de4-2b32b1da5389
  3. In the latter case, the last played note is not shown as released on VST interfaces (apparently, the information that playback was stopped is not sent to the VST user interface).
    https://github.com/musescore/MuseScore/assets/120221700/d26c8254-2d9a-4add-96ba-1b4352bae5d2
    (4. In long scores, playback is not triggered for the first note of any bar: this issue is known as #22638)
Steps to reproduce

See above

Screenshots/Screen recordings

No response

MuseScore Version

Tested on latest 4.4 master and 4.3. Probably not a regression in MS4.

Regression

I don't know

Operating system

Win10 (22H2); RAM: 16Go; CPU: Intel Core i5-9300H (2.40GHz)

Additional context

Tested on different sounds in DecentSampler and Spitfire Audio LABS.

Reported on musescore.org (https://musescore.org/en/node/341622, https://musescore.org/en/node/298806, https://musescore.org/en/node/346340)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.