musescore / musescore/MuseScore

Use QML color picker

Open
#23,244 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

P1 tech debt
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Your idea

We are currently using a QColorDialog to allow the user to select a color, this is a QWidget class - this leads to all sorts of problems, for example https://github.com/musescore/MuseScore/issues/23208

We must use the qml version of this dialog. An example of such a transition is demonstrated for the folder selection dialog in this commit https://github.com/musescore/MuseScore/commit/7512c3b109022a967fad32381e11e6808dd9fc20

Problem to be solved

Another step towards abandoning QWidget in the project

Prior art

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the QColorDialog usage in the MuseScore codebase and read commit 7512c3b109022a967fad32381e11e6808dd9fc20 for the folder-selection transition pattern. Replace the QWidget-based color dialog with its QML counterpart, with the existing color-selection behavior preserved and QWidget usage reduced.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.